Change in vdsm[master]: Improve dom xml gereration

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Fri Jan 11 13:40:08 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Improve dom xml gereration
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 643: 
Line 644:         oselem = XMLElem('os')
Line 645:         self.dom.appendChild(oselem)
Line 646:         oselem.newChild('type', text='hvm', arch='x86_64',
Line 647:                         machine=self.conf.get('emulatedMachine', 'pc'))
Pradipta, I think this problem should be resolved in another patch. Are you fine with it?
Line 648: 
Line 649:         qemu2libvirtBoot = {'a': 'fd', 'c': 'hd', 'd': 'cdrom', 'n': 'network'}
Line 650:         for c in self.conf.get('boot', ''):
Line 651:             oselem.newChild('boot', dev=qemu2libvirtBoot[c])


--
To view, visit http://gerrit.ovirt.org/10054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib936740fcbeeee551e13abfed7fd91f2a159e351
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list