Change in vdsm[master]: [WIP]normalize startup:export priviledged launch for startin...

ybronhei at redhat.com ybronhei at redhat.com
Thu Jan 10 10:30:56 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: [WIP]normalize startup:export priviledged launch for starting supervdsm
......................................................................


Patch Set 2: (2 inline comments)

so only svdsm can kill itself? when we'll run svdsm as a deamon it can work.. but now, if svdsm kills itself, how it supposed to launch again? you want to keep svdsm init process alive?

....................................................
File vdsm/supervdsm.py
Line 98:         # Declaration of public variables that keep files' names that svdsm
Line 99:         # uses. We need to be able to change these variables so that running
Line 100:         # tests doesn't disturb and already running VDSM on the host.
Line 101:         self.setIPCPaths(PIDFILE, TIMESTAMP, ADDRESS)
Line 102:         self._svdsm = None
if you omit the restart here why do you base your patch over it (gerrit.ovirt.org/#/c/9691)
Line 103: 
Line 104:     def setIPCPaths(self, pidfile, timestamp, address):
Line 105:         self.pidfile = pidfile
Line 106:         self.timestamp = timestamp


Line 136:         try:
Line 137:             if self._isSvdsmAlive():
Line 138:                 with open(self.pidfile, "r") as f:
Line 139:                     pid = int(f.read().strip())
Line 140:                 misc.execCmd([constants.EXT_KILL, "-9", str(pid)], sudo=True)
if we run as root we don't need to run this command with sudo=True, and we can use os.kill
Line 141:         except Exception:
Line 142:             self._log.warn("Could not kill old Super Vdsm %s",
Line 143:                             exc_info=True)
Line 144: 


--
To view, visit http://gerrit.ovirt.org/10706
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a96267e6473b7dcfbe4367a215697c8a4cb8ff5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list