Change in vdsm[master]: dump the core of a domain

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Thu Jan 10 08:51:00 UTC 2013


ShaoHe Feng has posted comments on this change.

Change subject: dump the core of a domain
......................................................................


Patch Set 4: (4 inline comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 4873: # @to: the coreDump file
Line 4874: #
Line 4875: # @params:  coreDump parameters
Line 4876: #
Line 4877: # Since: 4.10.0
agree
Line 4878: #
Line 4879: # XXX: Split 'params' into direct parameters
Line 4880: ##
Line 4881: {'command': {'class': 'VM', 'name': 'coreDump'},


Line 4875: # @params:  coreDump parameters
Line 4876: #
Line 4877: # Since: 4.10.0
Line 4878: #
Line 4879: # XXX: Split 'params' into direct parameters
agree
Line 4880: ##
Line 4881: {'command': {'class': 'VM', 'name': 'coreDump'},
Line 4882:  'data': {'to': 'str', 'params': 'DumpParams'}}
Line 4883: 


....................................................
File vdsm_cli/vdsClient.py
Line 1633:         vmId = args[0]
Line 1634:         coreFile = args[1]
Line 1635:         params = {}
Line 1636:         if len(args) > 2:
Line 1637:             for arg in args[2:]:
yes, I can accept. when I write this patch, I call  _eqsplit,  but there is a bug in it, submit a patch to fix _eqsplit.

but it need time to merged. so I re-write this code(line 1637-1642).
Line 1638:                 kv = arg.split('=', 1)
Line 1639:                 kv.append('')
Line 1640:                 k, v = kv[:2]
Line 1641:                 params[k] = v


Line 1643:             params[k] = v = v.lower()
Line 1644:             if not v:
Line 1645:                 params[k] = v = "true"
Line 1646:             if k not in dumpParams:
Line 1647:                 raise ValueError("Invalid optoin %s" % k)
good catch
Line 1648:             if v not in ["true", "false"]:
Line 1649:                 raise ValueError("Invalid argument value: %s. "
Line 1650:                                  "It should be:%s=<True|False>"
Line 1651:                                  % (v, k))


--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list