Change in vdsm[master]: dump the core of a domain

asegurap at redhat.com asegurap at redhat.com
Wed Jan 9 16:44:51 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: dump the core of a domain
......................................................................


Patch Set 4: (7 inline comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 4856: # @reset:     #optional Reset the domain after core dump
Line 4857: #
Line 4858: # @memory-only: #optional Dump domain's memory only
Line 4859: #
Line 4860: # Since: 4.10.0
It will probably be 4.10.4
Line 4861: #
Line 4862: ##
Line 4863: {'type': 'DumpParams',
Line 4864:  'data': {'*crash': 'bool', '*live:': 'bool',


Line 4873: # @to: the coreDump file
Line 4874: #
Line 4875: # @params:  coreDump parameters
Line 4876: #
Line 4877: # Since: 4.10.0
It will probably be 4.10.4
Line 4878: #
Line 4879: # XXX: Split 'params' into direct parameters
Line 4880: ##
Line 4881: {'command': {'class': 'VM', 'name': 'coreDump'},


Line 4875: # @params:  coreDump parameters
Line 4876: #
Line 4877: # Since: 4.10.0
Line 4878: #
Line 4879: # XXX: Split 'params' into direct parameters
As we discussed, you will probably want to drop this.
Line 4880: ##
Line 4881: {'command': {'class': 'VM', 'name': 'coreDump'},
Line 4882:  'data': {'to': 'str', 'params': 'DumpParams'}}
Line 4883: 


Line 4885: # @VM.dumpCancel:
Line 4886: #
Line 4887: # Cancel the currently outgoing core dump process.
Line 4888: #
Line 4889: # Since: 4.10.0
It will probably be 4.10.4
Line 4890: ##
Line 4891: {'command': {'class': 'VM', 'name': 'dumpCancel'}}
Line 4892: 
Line 4893: ##


Line 4894: # @VM.dumpStatus:
Line 4895: #
Line 4896: # Reports the state of the currently core dump process
Line 4897: #
Line 4898: # Since: 4.10.0
It will probably be 4.10.4
Line 4899: #
Line 4900: ##
Line 4901: {'command': {'class': 'VM', 'name': 'dumpStatus'}}
Line 4902: 


....................................................
File vdsm_cli/vdsClient.py
Line 1633:         vmId = args[0]
Line 1634:         coreFile = args[1]
Line 1635:         params = {}
Line 1636:         if len(args) > 2:
Line 1637:             for arg in args[2:]:
You could replace this with _eqsplit if you would accept the "lazy parameters with '='. Otherwise it is fine as it is.
Line 1638:                 kv = arg.split('=', 1)
Line 1639:                 kv.append('')
Line 1640:                 k, v = kv[:2]
Line 1641:                 params[k] = v


Line 1643:             params[k] = v = v.lower()
Line 1644:             if not v:
Line 1645:                 params[k] = v = "true"
Line 1646:             if k not in dumpParams:
Line 1647:                 raise ValueError("Invalid optoin %s" % k)
typo. It should say option.
Line 1648:             if v not in ["true", "false"]:
Line 1649:                 raise ValueError("Invalid argument value: %s. "
Line 1650:                                  "It should be:%s=<True|False>"
Line 1651:                                  % (v, k))


--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list