Change in vdsm[master]: functional tests: Wait till backend server of storage connec...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Jan 9 09:48:22 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: functional tests: Wait till backend server of storage connection reference is connected
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 363:         for _refid, status in r['results'].iteritems():
Line 364:             self.asserts.assertEquals(status, 0)
Line 365:         self.asserts.retryAssert(
Line 366:             partial(self._assertBackendConnected, connections), timeout=40)
Line 367: 
Thanks Deepak, I update the patch according to your suggestions, it's very helpful.
Line 368:     def _genTypeSpecificArgs(self, connections, rollback):
Line 369:         raise RuntimeError("Not implemented")
Line 370: 
Line 371:     def prepare(self, backendDef, rollback):


--
To view, visit http://gerrit.ovirt.org/10352
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I466b8e8cbfe6e1b04f8ad902f54fa1177b746feb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list