Change in vdsm[master]: pool: ignore refreshStoragePool calls on the SPM

smizrahi at redhat.com smizrahi at redhat.com
Mon Jan 7 22:13:37 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: pool: ignore refreshStoragePool calls on the SPM
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Even though I agree with both changes please split them up.

I know that in 3 weeks someone is going to wonder why we are validating the you are not the SPM on disconnect. I would like it to have a specific commit message. I gave a +1 in case this is not possible or just annoying for you.

....................................................
File vdsm/storage/hsm.py
Line 789: 
Line 790:         vars.task.getSharedLock(STORAGE, spUUID)
Line 791: 
Line 792:         try:
Line 793:             # The refreshStoragePool command is an HSM command and
There is no such thing as an HSM command or an SPM command.

The refreshStoragePool() command is only valid non SPM hosts as the SPM is always up to date.

I don't understand why an exception is recommended.
Line 794:             # should not be issued (and executed) on the SPM. At the
Line 795:             # moment we just ignore it for legacy reasons but in the
Line 796:             # future vdsm could raise an exception.
Line 797:             self.validateNotSPM(spUUID)


--
To view, visit http://gerrit.ovirt.org/10450
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c275bfb15e4948c2e28ea21fac787c36bb48e97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list