Change in vdsm[master]: avoid race between load dev rules and trigger the rule

vvolansk at redhat.com vvolansk at redhat.com
Sun Jan 6 12:52:29 UTC 2013


Vered Volansky has posted comments on this change.

Change subject: avoid race between load dev rules and trigger the rule
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2919:         Warning: Internal use only.
Line 2920:         """
Line 2921:         supervdsm.getProxy().appropriateDevice(guid, thiefId)
Line 2922:         #4s is enough for udevd to reload new rules
Line 2923:         time.sleep(4)
It's not a good idea to use timer.sleep. It would be better to use udevadm control --reload-rules inside udevTrigger, so you only block the needed amount of time, if any.
Line 2924:         supervdsm.getProxy().udevTrigger(guid)
Line 2925:         try:
Line 2926:             devPath = '/dev/mapper/%s' % guid
Line 2927:             fileUtils.validateQemuReadable(devPath)


--
To view, visit http://gerrit.ovirt.org/6780
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I718d62e67b0a228f2510233c5dd9d1d94c4a736c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list