Change in vdsm[master]: Refactor communication infra

danken at redhat.com danken at redhat.com
Fri Jan 4 20:09:59 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Refactor communication infra
......................................................................


Patch Set 15: I would prefer that you didn't submit this

(2 inline comments)

marking -1 for two unanswered questions. I know they are not the most urgent issues ever, but I'd like to have them addressed (even with "my code is great, the reviewer is an idiot").

....................................................
File vdsm_api/BindingJsonRpc.py
Line 37:         self._reactors = reactors
Line 38: 
Line 39:     def _createTcpReactor(self, cfg):
Line 40:         address = cfg.get("ip", "0.0.0.0")
Line 41:         port = cfg.get("port", 4044)
do we really want this 4044 default in this level?
Line 42:         return TCPReactor((address, port), self.server)
Line 43: 
Line 44:     def start(self):
Line 45:         for reactor in self._reactors:


....................................................
File vdsm_api/jsonrpc/tcpReactor.py
Line 63:         buffLen = len(self._buffer)
Line 64:         if buffLen < _Size.size:
Line 65:             return None
Line 66: 
Line 67:         if buffLen > self.buffsize:
could this happen unless there's a bug in self._conn.recv()? I feel as if this condition could be dropped.
Line 68:             self._conn.close()
Line 69:             self._sendData = []
Line 70: 
Line 71:         msgLen = _Size.unpack(self._buffer[:_Size.size])[0]


--
To view, visit http://gerrit.ovirt.org/9986
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a65364824cc8433263ccf6ed44f1f97141eff2c
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list