Change in vdsm[master]: netinfo: remove special characters from DUMMY_BRIDGE

fsimonce at redhat.com fsimonce at redhat.com
Fri Jan 4 12:45:12 UTC 2013


Federico Simoncelli has uploaded a new change for review.

Change subject: netinfo: remove special characters from DUMMY_BRIDGE
......................................................................

netinfo: remove special characters from DUMMY_BRIDGE

Creating a bridge with special shell characters (";") can potentially
break system scripts. Since there's not a specific requirement to use
semicolons in the bridge name the string has been sanitized.

Change-Id: I3e5a03a1f88495731bc107d5301fab43354f4e36
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/netinfo.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/10653/1

diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py
index aebe085..f21da20 100644
--- a/vdsm/netinfo.py
+++ b/vdsm/netinfo.py
@@ -43,7 +43,7 @@
 PROC_NET_VLAN = '/proc/net/vlan/'
 
 LIBVIRT_NET_PREFIX = 'vdsm-'
-DUMMY_BRIDGE = ';vdsmdummy;'
+DUMMY_BRIDGE = 'vdsmdummy'
 
 
 def _match_nic_name(nic, patterns):


--
To view, visit http://gerrit.ovirt.org/10653
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5a03a1f88495731bc107d5301fab43354f4e36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list