Change in vdsm[master]: tests: Test schema validity

agl at us.ibm.com agl at us.ibm.com
Wed Jan 2 14:40:52 UTC 2013


Adam Litke has posted comments on this change.

Change subject: tests: Test schema validity
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File tests/schemaTests.py
Line 34:     for f in localpath, installedpath:
Line 35:         if os.access(f, os.R_OK):
Line 36:             return f
Line 37:     raise Exception("Unable to find schema in %s or %s",
Line 38:                     localpath, installedpath)
Done
Line 39: 
Line 40: 
Line 41: class SchemaTest(TestCaseBase):
Line 42:     def setUp(self):


Line 41: class SchemaTest(TestCaseBase):
Line 42:     def setUp(self):
Line 43:         self.schema = findSchema()
Line 44: 
Line 45:     def testSchemaParse(self):
Done
Line 46:         with open(self.schema) as f:


Line 43:         self.schema = findSchema()
Line 44: 
Line 45:     def testSchemaParse(self):
Line 46:         with open(self.schema) as f:
Line 47:             vdsmapi.parse_schema(f)
We need to support running the tests from the source directory and also when there installed by the vdsm-tests package.


--
To view, visit http://gerrit.ovirt.org/10050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7680aaf8eb41546e3a8d38e405c7f9ed8bdd192
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list