Change in vdsm[master]: Catch libvirt timeout and return an error on setVmTicket

rgolan at redhat.com rgolan at redhat.com
Thu Feb 28 10:26:22 UTC 2013


Roy Golan has posted comments on this change.

Change subject: Catch libvirt timeout and return an error on setVmTicket
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 2415:             self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 2416:         except TimeoutError as tmo:
Line 2417:             err = errCode['ticketErr']
Line 2418:             err['exception'] = tmo
Line 2419:             return err
just realize this will set the exception object for that error and I should really get a new error copy in hand

 err =  dict(errCode['ticketErr'])
 err['exception'] = tmo
Line 2420:         hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf, params)
Line 2421:         return {'status': doneCode}
Line 2422: 
Line 2423:     def _reviveTicket(self, newlife):


--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list