Change in vdsm[master]: Ignore postZero flag when deleting an image on a fileSD.

abaron at redhat.com abaron at redhat.com
Thu Feb 28 07:49:20 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Ignore postZero flag when deleting an image on a fileSD.
......................................................................


Patch Set 3: Looks good to me, approved

Wrt postZero explanation - that is was and will be part of the existing code, nothing new in this patch so no reason to block it on that (although it should indeed be documented).
I don't think the bugzilla is the place to document it as it would be difficult find.  I believe the right place would be in the code.

Wrt smart engine dumb vdsm, actually it is the reverse.  We're working towards having more policy and logic in vdsm to make it more independent in cases engine is not available etc.  Having said that, it has nothing to do with this patch.  This patch is reverting a change in behaviour that caused regressions.  The behaviour in this patch is as it used to be in the past.

--
To view, visit http://gerrit.ovirt.org/12404
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief50d6174fd20e16f2fdf48a6cd512d20b9f407d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list