Change in vdsm[master]: hooks: Add disk hot plug/unplug hooks

abaron at redhat.com abaron at redhat.com
Wed Feb 27 22:27:16 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: hooks: Add disk hot plug/unplug hooks
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/vdsmd.8.in
Line 66: representation of the relevant virtual machine.
Line 67: The uuid of the virtual machine may be deduced from that xml, but it is also
Line 68: available as the environment variable
Line 69: .B vmId.
Line 70: Hooks that handle NIC hotplug and hotunplug has the _hook_domxml variable but it
Seeing as this is the standard I guess you'll need to update that the _hook_domxml contains the drive definition and not the VM.
While at it, you can s/has/have/ in this line.
Line 71: contanins the representation of the NIC rather than the VM.
Line 72: 
Line 73: On top of these, @ENGINENAME@ allows to set a collection of "custom parameters" for
Line 74: each virtual machine.  Each of these parameters is provided to hooks as an


--
To view, visit http://gerrit.ovirt.org/12479
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10b689964fad3a1118974f7ba7b91e795cbffd1f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list