Change in vdsm[master]: Don't crash on libvirt network re-definition.

danken at redhat.com danken at redhat.com
Wed Feb 27 13:19:53 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Don't crash on libvirt network re-definition.
......................................................................


Patch Set 6: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 408:             with open(file_path, 'r') as conf_file:
Line 409:                 for line in conf_file:
Line 410:                     if line.startswith('BRIDGE=' + network):
Line 411:                         port = file_path[file_path.rindex('-') + 1:]
Line 412:                         logging.debug('port %s found in ifcfg for %s', port,
I'm not crazy about this multitude of logs, but if you like it, it's fine.
Line 413:                                       network)
Line 414:                         ports.append(port)
Line 415:         return ports
Line 416: 


--
To view, visit http://gerrit.ovirt.org/10901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list