Change in vdsm[master]: Adding sudo rules to multipath and removing unused rules

danken at redhat.com danken at redhat.com
Tue Feb 26 11:53:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Adding sudo rules to multipath and removing unused rules
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/sudoers.vdsm.in
Line 33:     @PERSIST_PATH@ /etc/multipath.conf, \
Line 34:     @UNPERSIST_PATH@ /etc/multipath.conf, \
Line 35:     @CP_PATH@ /etc/multipath.conf *, \
Line 36:     @CP_PATH@ * /etc/multipath.conf, \
Line 37:     @MULTIPATH_PATH@ *, \
I believe that having nothing after the executable name means "all possible args". a single asterisk means "exactly one arg". So unless you are fixing a bug here, please do not touch the line.
Line 38:     @BLOCKDEV_PATH@ --getsize64 *, \
Line 39:     @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \
Line 40:     @SERVICE_PATH@ vdsmd *, \
Line 41:     @REBOOT_PATH@ -f, \


--
To view, visit http://gerrit.ovirt.org/12226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie732400423f12b0a783bd251b4e2cc2e2409ffec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list