Change in vdsm[master]: Ignore postZero flag when deleting an image on a fileSD.

ykaplan at redhat.com ykaplan at redhat.com
Tue Feb 26 09:33:45 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: Ignore postZero flag when deleting an image on a fileSD.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/fileSD.py
Line 364:             raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
Line 365: 
Line 366:     def zeroImage(self, sdUUID, imgUUID, volsImgs):
Line 367:         self.log.warning(imgUUID, sdUUID, "image %s on a fileSD %s will be "
Line 368:                          "not zeroed." % (imgUUID, sdUUID))
and also why do you state the imgUUID and sdUUID twice?
Line 369:         self.deleteImage(sdUUID, imgUUID, volsImgs)
Line 370: 
Line 371:     def getAllVolumes(self):
Line 372:         """


--
To view, visit http://gerrit.ovirt.org/12404
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief50d6174fd20e16f2fdf48a6cd512d20b9f407d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list