Change in vdsm[master]: tool: _enable_bond_dev: reopen bonding_masters per bond

danken at redhat.com danken at redhat.com
Mon Feb 25 19:22:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: tool: _enable_bond_dev: reopen bonding_masters per bond
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm-tool/load_needed_modules.py.in
Line 46:     # @ENGINENAME@ currently assumes that all bonding devices pre-exist
Line 47:     existing = set(file(MASTER_FILE).read().split())
Line 48:     for bond in REQUIRED - existing:
Line 49:         with open(MASTER_FILE, 'w') as f:
Line 50:             f.write('+%s\n' % bond)
My testing shows that you are correct, but frankly, I like that trailing newline. Imagine if the writing was buffered, and that the calling process died while writing +bond9999999999. The resulting interface is not deterministic.

I suppose that this cannot happen when passing a single buffer to write(2), but I kinda like the termination. Please reconsider your -1.
Line 51: 
Line 52: 
Line 53: @expose('load-needed-modules')
Line 54: def load_needed_modules():


--
To view, visit http://gerrit.ovirt.org/12409
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4693a3d2cc3beba0b5961d16fb1ef25170f99f9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list