Change in vdsm[master]: Use absolute path of multipath.conf file

ybronhei at redhat.com ybronhei at redhat.com
Mon Feb 25 17:00:47 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Use absolute path of multipath.conf file
......................................................................


Patch Set 2: (3 inline comments)

Dan, Please answer my comments so I'll proceed with that

....................................................
File vdsm/sudoers.vdsm.in
Line 34:     @PERSIST_PATH@ /etc/multipath.conf, \
Line 35:     @PERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 36:     @UNPERSIST_PATH@ /etc/multipath.conf, \
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ * /etc/multipath.conf *, \
no, this line allows us to copy /etc/multipath.conf to another files, line 22 allows only copy something to /etc/multipath.conf. anyway, this line contains line 22 in it so we can omit 22.. ill do that
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
Line 40:     @MULTIPATH_PATH@, \
Line 41:     @MULTIPATH_PATH@ -F, \
Line 42:     @BLOCKDEV_PATH@ --getsize64 *, \


Line 35:     @PERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 36:     @UNPERSIST_PATH@ /etc/multipath.conf, \
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ * /etc/multipath.conf *, \
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
i have no idea.. we don't have backup folder at all.. but it doesn't related to the patch. do you prefer that i'll remove it? it doesn't add anything.. you have it also in line 37
Line 40:     @MULTIPATH_PATH@, \
Line 41:     @MULTIPATH_PATH@ -F, \
Line 42:     @BLOCKDEV_PATH@ --getsize64 *, \
Line 43:     @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \


Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ * /etc/multipath.conf *, \
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
Line 40:     @MULTIPATH_PATH@, \
Line 41:     @MULTIPATH_PATH@ -F, \
This is not related to the bug as described now. only line 38 is necessary to fix the copy error. I left this line with no reason... Pavel - if there is reason for that please comment and tell when is it necessary. Thanks.
Line 42:     @BLOCKDEV_PATH@ --getsize64 *, \
Line 43:     @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \
Line 44:     @SERVICE_PATH@ vdsmd *, \
Line 45:     @REBOOT_PATH@ -f, \


--
To view, visit http://gerrit.ovirt.org/12226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie732400423f12b0a783bd251b4e2cc2e2409ffec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list