Change in vdsm[master]: tc: set/unset promisc when it's really needed

mhuntxu at gmail.com mhuntxu at gmail.com
Mon Feb 25 14:36:52 UTC 2013


Hunt Xu has posted comments on this change.

Change subject: tc: set/unset promisc when it's really needed
......................................................................


Patch Set 2: Verified

(1 inline comment)

....................................................
File vdsm/tc.py
Line 182:     if bool(flags & ethtool.IFF_PROMISC) != on:
Line 183:         if on:
Line 184:             flags |= ethtool.IFF_PROMISC
Line 185:         else:
Line 186:             flags &= ~ethtool.IFF_PROMISC
It's cooler though it took me some time to be clear. :P
Line 187: 
Line 188:         set_flags(dev, flags)
Line 189: 
Line 190: 


--
To view, visit http://gerrit.ovirt.org/12307
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d38e2f13a059ea916892ab8247509e2e0b612e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list