Change in vdsm[master]: vdsm: only specify graphics ports as needed for spice

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Feb 25 09:38:51 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: only specify graphics ports as needed for spice
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 803:         <channel type='spicevmc'>
Line 804:            <target type='virtio' name='com.redhat.spice.0'/>
Line 805:         </channel>
Line 806:         """
Line 807:         graphicsAttrs = {}
Well I did not yet add anyone for reviewing. I came to the realization that there's a bigger issue here with this patch. I need to figure out how to solve it before I am going to fix it. And yes it breaks the unit tests, because the unit tests are expecting port and autoPort to be there all the time, autoPort is implied by passing -1 as port.
Line 808:         if self.conf['display'] == 'vnc':
Line 809:             graphicsAttrs['type'] = 'vnc'
Line 810:             graphicsAttrs['port'] = self.conf['displayPort']
Line 811:         elif 'qxl' in self.conf['display']:


--
To view, visit http://gerrit.ovirt.org/12291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc866259d4cfa95a3b137dce101ce04f215f9f5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list