Change in vdsm[master]: lvm: Fix due to pyflakes newer version in F18

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Feb 24 14:15:12 UTC 2013


Eduardo has posted comments on this change.

Change subject: lvm: Fix due to pyflakes newer version in F18
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Discussed with danken.

....................................................
File vdsm/storage/lvm.py
Line 604:                 lvs = self._reloadlvs(vgName)
Line 605:             else:
Line 606:                 lvs = dict(self._lvs)
Line 607:             # lvs = self._reloadlvs()
Line 608:             lvs = [lvVal for lvVal in lvs.values()
In spite that this solves the pyflakes issue I think the error is false. There is no override of any local variable since lv was not instatiated yet if you reach the else. There are two different lv definition in  if - else clauses which  are mutually excluyent. Edri should fix pyflakes or the build.
Line 609:                    if not isinstance(lvVal, Stub) and
Line 610:                    (lvVal.vg_name == vgName)]
Line 611:             res = lvs
Line 612:         return res


--
To view, visit http://gerrit.ovirt.org/12379
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69800914ad095deb57fca4c243ce65017e66ba14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list