Change in vdsm[master]: Avoid warnings during service start

danken at redhat.com danken at redhat.com
Sun Feb 24 12:01:05 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Avoid warnings during service start
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 416:               /bin/grep libvirtd.upstart | /usr/bin/tail -1`
Line 417:     target=/etc/init/libvirtd.conf
Line 418: 
Line 419:     if [[ -f "$packaged" ]] && [[ ! -f "$target" ]] ||
Line 420: 	! diff -q "$packaged" "$target" >/dev/null 2>&1
again: I think that automatically swalling stderr is bad. we do it elsewhere in this file, but it is still bad and should be avoided.

also, tabs in this file are frowned upon.
Line 421:     then
Line 422:         /bin/cp -p "$packaged" "$target" || return 1
Line 423:         /sbin/initctl reload-configuration
Line 424:     fi


--
To view, visit http://gerrit.ovirt.org/12266
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d3c27df3385621619451ded0b113f932d9834a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list