Change in vdsm[master]: Return the result directly instead of generator when getting...

danken at redhat.com danken at redhat.com
Sat Feb 23 21:22:47 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Return the result directly instead of generator when getting network for interface
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

minor comment on comment.

....................................................
Commit Message
Line 3: AuthorDate: 2012-12-05 15:49:57 +0800
Line 4: Commit:     Mark Wu <wudxw at linux.vnet.ibm.com>
Line 5: CommitDate: 2013-02-21 14:46:04 +0800
Line 6: 
Line 7: Return the result directly instead of generator when getting network
Yes, the current name and implementation of netinfo.getNetworksForIface is misleading. Thanks.

Would you rewrite the subject line in the spirit of:

 netinfo: there may be up to one network attached directly to an Iface
Line 8: for interface
Line 9: 
Line 10: Since one nic could be only used for one non-VLANed bridge or one non-VLANed
Line 11: bridgeless network, it needn't continue to check other networks after


--
To view, visit http://gerrit.ovirt.org/9737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80c47d0f0df70de73993ef0c09f69cbf882f6629
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list