Change in vdsm[master]: gluster: verbs for managing services

barumuga at redhat.com barumuga at redhat.com
Fri Feb 22 10:52:29 UTC 2013


Bala.FA has posted comments on this change.

Change subject: gluster: verbs for managing services
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/gluster/api.py
Line 222:         serviceStatus = []
Line 223:         for serviceName in serviceNames:
Line 224:             out = self.svdsmProxy.glusterServiceManage(serviceName,
Line 225:                                                        action,
Line 226:                                                        failOnError)
Don't expose failOnError to svdsmProxy.glusterServiceManage().  This logic should be limited to this.
Line 227:             serviceStatus.append(out)
Line 228: 
Line 229:         return {'services': serviceStatus}
Line 230: 


Line 231:     @exportAsVerb
Line 232:     def servicesGet(self, serviceNames, failOnError=False, options=None):
Line 233:         serviceStatus = []
Line 234:         for serviceName in serviceNames:
Line 235:             out = self.svdsmProxy.glusterServiceGet(serviceName, failOnError)
same here
Line 236:             serviceStatus.append(out)
Line 237: 
Line 238:         return {'services': serviceStatus}
Line 239: 


....................................................
File vdsm/gluster/cli.py
Line 926:         if failOnError:
Line 927:             raise ge.GlusterServiceGetFailedException(err=[e.message])
Line 928:         else:
Line 929:             return {"name": serviceName, "status": "ERROR",
Line 930:                     "pid": "", "message": e.message}
1. serviceManage() and serviceGet() logic should go to gluster/api.py into appropriate methods.

2. remove serviceManage() and serviceGet() from cli.py


....................................................
File vdsm/Makefile.am
Line 64: 	netinfo.py \
Line 65: 	qemuImg.py \
Line 66: 	SecureXMLRPCServer.py \
Line 67: 	utils.py \
Line 68: 	service.py
keep sorted the list
Line 69: 
Line 70: nodist_vdsmpylib_PYTHON = \
Line 71: 	config.py \
Line 72: 	constants.py


--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list