Change in vdsm[master]: Using CrabRPC to communicate between vdsm and super vdsm

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Fri Feb 22 08:52:22 UTC 2013


Royce Lv has posted comments on this change.

Change subject: Using CrabRPC to communicate between vdsm and super vdsm
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/vdsm
Line 133: 
Line 134:     vdsmPid = os.getpid()
Line 135:     vdsm_r, svdsm_w = os.pipe()
Line 136:     svdsm_r, vdsm_w = os.pipe()
Line 137:     supervdsm.setPipe(vdsm_r, vdsm_w)
I don't understand why vdsm cares how it is communicate to supervdsm, whether it's socket or pipe, they are managed inside in the proxy/server, not pass from the outside. socket/pipe are transparent to RPC users.(remoteFileHandler.py for reference )
Line 138:     son_pid = os.fork()
Line 139: 
Line 140:     if son_pid != 0:
Line 141:         startSuperVdsm(svdsm_r, svdsm_w, son_pid)


Line 137:     supervdsm.setPipe(vdsm_r, vdsm_w)
Line 138:     son_pid = os.fork()
Line 139: 
Line 140:     if son_pid != 0:
Line 141:         startSuperVdsm(svdsm_r, svdsm_w, son_pid)
I thought the library offered us a series convenient functions to query the process status we're likely want to use when need changes (such as 'isAlive','terminate', 'join', etc),  we can't reinvent another wrapper because the current one may have bugs, just my ho.
Line 142: 
Line 143:     else:
Line 144:         dropPrivileges()
Line 145:         log = initVdsmLogger()


--
To view, visit http://gerrit.ovirt.org/11910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f1053e7d1264003fa265e44899d8b02f98bd68a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list