Change in vdsm[master]: Avoid warnings during service start

danken at redhat.com danken at redhat.com
Thu Feb 21 13:56:46 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Avoid warnings during service start
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 415:     packaged=`/bin/rpm -ql libvirt libvirt-daemon | \
Line 416:               /bin/grep libvirtd.upstart | /usr/bin/tail -1`
Line 417:     target=/etc/init/libvirtd.conf
Line 418: 
Line 419:     if [[ -f "$packaged" ]] && ! diff -q "$packaged" "$target" >/dev/null 2>&1;
this is a bad idea since it would hide meaningful warnings, too.

I think that having something like

 if [[ -f "$packaged" ]] && [[ ! -f "$target" ]] || ! diff -q "$packaged" "$target" >/dev/null 2>&1

is safer (please check my logic).
Line 420:     then
Line 421:         /bin/cp -p "$packaged" "$target" || return 1
Line 422:         /sbin/initctl reload-configuration
Line 423:     fi


--
To view, visit http://gerrit.ovirt.org/12266
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d3c27df3385621619451ded0b113f932d9834a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list