Change in vdsm[master]: Do not delete the template when zeroing a dependant image.

danken at redhat.com danken at redhat.com
Tue Feb 19 12:10:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Do not delete the template when zeroing a dependant image.
......................................................................


Patch Set 2:

Ayal, the nice thing about this fix is that it solves two clear bugs:
- dom.zeroImage() was called with vol names instead of vol tuples by the zeroImage task
- zeroImage garbled a list of volume that was different of the one deleted by deleteImage

The fix is simple, simetrical and localized.

Adding another flavour of getVolsOfImage() on top of it would require re-addressing the flow in hsm.deleteImage, and possible change the well-tested flow of non-post-zero delete.

--
To view, visit http://gerrit.ovirt.org/12178
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e472334efa9dadb5389db70b0953f88b9be858a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list