Change in vdsm[master]: hook_faqemu: using libvirt instead of hacking it

danken at redhat.com danken at redhat.com
Tue Feb 19 11:20:08 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hook_faqemu: using libvirt instead of hacking it
......................................................................


hook_faqemu: using libvirt instead of hacking it

Passing -no-kvm / -enable-kvm directly to qemu is a rather bad idea,
if you do not change domain type. These options should be set by
libvirt upon the domain type: domain type='kvm' will engage kvm
and domain type='qemu' will use faqemu correctly in all libvirt
versions on any host type.

Since vdsm-faqemu do not provide nothing but this option hack,
it can be safely removed, libvirt will do all the work. Beside of
that, there is no need for /dev/kvm creation hack, since domain
type='qemu' does not check it on the startup.

Signed-off-by: Peter V. Saveliev <peet at redhat.com>
Change-Id: I85f0208bf55f26c5bd146e3a81f28fdc56b8c5ce
---
M vdsm.spec.in
M vdsm_hooks/faqemu/Makefile.am
D vdsm_hooks/faqemu/after_vdsm_stop.py
M vdsm_hooks/faqemu/before_vm_start.py
D vdsm_hooks/faqemu/vdsm-faqemu
5 files changed, 2 insertions(+), 76 deletions(-)

Approvals:
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified


--
To view, visit http://gerrit.ovirt.org/12084
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85f0208bf55f26c5bd146e3a81f28fdc56b8c5ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list