Change in vdsm[master]: image: do not delete the template on deleteImage

fsimonce at redhat.com fsimonce at redhat.com
Mon Feb 18 13:09:44 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: image: do not delete the template on deleteImage
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1439:         # on data domains, images should not be deleted if they are templates
Line 1440:         # being used by other images.
Line 1441:         isTemplateWithChildren = False
Line 1442:         for v in volsByImg.itervalues():
Line 1443:             if len(v.imgs) > 1 and v.imgs[0] == imgUUID:
This condition would be true if you try to delete 'img1' in a situation as the following:

 (vol1, [img1, img2]) <- (vol1, [img2]) <- (vol2, [img2])
Line 1444:                 isTemplateWithChildren = True
Line 1445:                 break
Line 1446: 
Line 1447:         if not isTemplateWithChildren:


--
To view, visit http://gerrit.ovirt.org/12105
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list