Change in vdsm[master]: vdsm.spec: Adding with_systemd macro

danken at redhat.com danken at redhat.com
Sat Feb 16 20:58:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: Adding with_systemd macro
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm.spec.in
Line 17: %global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
Line 18: %endif
Line 19: 
Line 20: # Systemd macro
Line 21: %if 0%{?fedora} >= 15
what about el7? the whole point was to capture both platforms with one macro.
Line 22: %global with_systemd 1
Line 23: %endif
Line 24: 
Line 25: # Default to skipping autoreconf.  Distros can change just this one line


Line 463: %else
Line 464: # Install the configuration sample
Line 465: install -Dm 0644 vdsm/vdsm.conf.sample \
Line 466:                  %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 467: 
I think this should be %if'ed too.
Line 468: # Install the systemd scripts
Line 469: install -Dm 0755 vdsm/vdsmd.init %{buildroot}/lib/systemd/systemd-vdsmd
Line 470: install -Dm 0644 vdsm/vdsmd.service %{buildroot}%{_unitdir}/vdsmd.service
Line 471: install -Dm 0644 vdsm/vdsm-restore-net-config.service \


Line 631: %doc COPYING README vdsm/vdsm.conf.sample vdsm_api/vdsm-api.html
Line 632: %if 0%{?rhel}
Line 633: %{_initrddir}/vdsmd
Line 634: %{_initrddir}/vdsm-restore-net-config
Line 635: %else
this should be available in el7, I suppose.
Line 636: /lib/systemd/systemd-vdsmd
Line 637: %{_unitdir}/vdsmd.service
Line 638: %{_unitdir}/vdsm-restore-net-config.service
Line 639: %endif


--
To view, visit http://gerrit.ovirt.org/12086
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcd8567868e16453ed6633f143a6b1fff8e9c454
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list