Change in vdsm[master]: add a json rpc funtional test which sets up a VM

agl at us.ibm.com agl at us.ibm.com
Fri Feb 15 14:01:25 UTC 2013


Adam Litke has posted comments on this change.

Change subject: add a json rpc funtional test which sets up a VM
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tests/functional/jsonrpcTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
You wrote this file, right?  The copyright should be to you and IBM and in 2013
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 109:         kernelArgsDistro['rhel'] = kernelArgsDistro['fedora']
Line 110:         if distro.lower() not in kernelArgsDistro:
Line 111:             raise SkipTest("Don't know how to perform direct kernel boot for "
Line 112:                            "%s" % distro)
Line 113: 
Can you also to an access test for the kernel and initrd?  I've found that tests like this fail because with selinux and svirt enabled, the qemu process cannot access the kernel and initrd.
Line 114:         template = {'vmId': '11111111-abcd-2222-ffff-333333333333',
Line 115:                     'vmName': 'vdsmKernelBootVM',
Line 116:                     'display': 'vnc',
Line 117:                     'kvmEnable': 'true',


--
To view, visit http://gerrit.ovirt.org/11386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I734614fdc9515e2883004aceafb36291ee44e59a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list