Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

danken at redhat.com danken at redhat.com
Thu Feb 14 20:19:30 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Issue when running make rpm in Fedora 18 without root access.
......................................................................


Issue when running make rpm in Fedora 18 without root access.

The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's
createNetwork and removeNetwork functions, but libvirt requires root access.
The current solution is to use monkey patch, and simply nullify the create
and remove network functions. The test now passes, but this might
not be the ideal solution to the problem.

Signed-off-by: Assaf Muller <amuller at redhat.com>
Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7
---
M tests/configNetworkTests.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list