Change in vdsm[master]: Caps: Include glusterfs packages

danken at redhat.com danken at redhat.com
Thu Feb 14 09:58:13 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Caps: Include glusterfs packages
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

would you mind rebasing this patch on top of my http://gerrit.ovirt.org/12047 ? It would save me some pains on el6 flavors with different rpm namings.

....................................................
File vdsm/caps.py
Line 329:     pkgs = {'kernel': kernelDict()}
Line 330: 
Line 331:     if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL):
Line 332:         GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-fuse',
Line 333:                             'glusterfs-geo-replication', 'glusterfs-rdma',
do we really need to track each of these individually?

would you keep them in the same order, here and in DEBIAN below?
Line 334:                             'glusterfs-server', 'glusterfs-swift',
Line 335:                             'glusterfs-swift-account',
Line 336:                             'glusterfs-swift-container', 'glusterfs-swift-doc',
Line 337:                             'glusterfs-swift-object', 'glusterfs-swift-proxy',


Line 361:         GLUSTER_PACKAGES = {
Line 362:             'gluster-swift': 'glusterfs-swift',
Line 363:             'gluster-swift-account': 'glusterfs-swift-account',
Line 364:             'gluster-swift-container': 'glusterfs-swift-container',
Line 365:             'gluster-swift-doc': 'glusterfs-swift-doc',
I'll have to take your word that these are the debian names for these packages.
Line 366:             'gluster-swift-object': 'glusterfs-swift-object',
Line 367:             'gluster-swift-plugin': 'glusterfs-ufo',
Line 368:             'gluster-swift-proxy': 'glusterfs-swift-proxy',
Line 369:             'glusterfs': 'glusterfs',


--
To view, visit http://gerrit.ovirt.org/11138
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list