Change in vdsm[master]: tests: Make getFreePort work in a multithreaded environment

danken at redhat.com danken at redhat.com
Wed Feb 13 20:18:25 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Make getFreePort work in a multithreaded environment
......................................................................


tests: Make getFreePort work in a multithreaded environment

getFreePort does not currently work reliably if multiple copies are running
concurrently.  Since each copy starts at the same port, the chance of choosing
the same port number at the same time is great.  Switch to letting the OS find
an available port.

This should fix the intermittent failures of jsonRpcTests and apiTests.

Change-Id: I6adcdde3fd0312ec532b261107af45dbc87f34f3
Signed-off-by: Adam Litke <agl at us.ibm.com>
---
M tests/jsonRpcUtils.py
1 file changed, 4 insertions(+), 18 deletions(-)

Approvals:
  Adam Litke: Verified
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6adcdde3fd0312ec532b261107af45dbc87f34f3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list