Change in vdsm[master]: Make vdsClient prettyprint dictionaries.

danken at redhat.com danken at redhat.com
Wed Feb 13 20:13:16 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make vdsClient prettyprint dictionaries.
......................................................................


Make vdsClient prettyprint dictionaries.

This helps a lot reading getVdsCaps.

This change makes that something like this:

networks = {'ovirtmgmt': {'iface': 'ovirtmgmt', 'addr': '10.34.60.86', 'cfg': {'IPV6INIT': 'yes', 'MTU': '1500', 'DELAY': '0', 'NM_CONTROLLED': 'no', 'BOOTPROTO': 'dhcp', 'DEVICE': 'ovirtmgmt', 'TYPE': 'Bridge', 'ONBOOT': 'yes'}, 'ipv6addrs': ['fe80::5054:ff:fe68:2557/64'], 'mtu': '1500', 'netmask': '255.255.252.0', 'stp': 'off', 'bridged': True, 'ipv6gateway': '::', 'gateway': '10.34.63.254', 'ports': ['eth0']}}

Becomes this:

networks = {'ovirtmgmt': {'addr': '10.34.60.86',
                          'bridged': True,
                          'cfg': {'BOOTPROTO': 'dhcp',
                                  'DELAY': '0',
                                  'DEVICE': 'ovirtmgmt',
                                  'IPV6INIT': 'yes',
                                  'MTU': '1500',
                                  'NM_CONTROLLED': 'no',
                                  'ONBOOT': 'yes',
                                  'TYPE': 'Bridge'},
                          'gateway': '10.34.63.254',
                          'iface': 'ovirtmgmt',
                          'ipv6addrs': ['fe80::5054:ff:fe68:2557/64'],
                          'ipv6gateway': '::',
                          'mtu': '1500',
                          'netmask': '255.255.252.0',
                          'ports': ['eth0'],
                          'stp': 'off'}}

Change-Id: I2553f4d8bfd85692b5204c67db8eca85517b1041
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm_cli/vdsClient.py
1 file changed, 17 insertions(+), 7 deletions(-)

Approvals:
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/11979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2553f4d8bfd85692b5204c67db8eca85517b1041
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list