Change in vdsm[master]: Change lvm filter use of regular expression to 'replace \x'

danken at redhat.com danken at redhat.com
Tue Feb 12 09:06:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Change lvm filter use of regular expression to 'replace \x'
......................................................................


Patch Set 4:

Dan's comments are always relevant, and particularly in this subject.

Back in http://gerrit.ovirt.org/#/c/9191/1/vdsm/storage/lvm.py (Yes, Nov 13), I asked to take care of funny characters.

A simple answer like "multipath encodes pipes and quotes just as lvm filter expects them", followed by a verification of the statement, would have been best.

--
To view, visit http://gerrit.ovirt.org/11852
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5428d3d8b1d0b10b083b663b12d3a6ceb7e3e69
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list