Change in vdsm[master]: After fail to connect to supervdsm more than 3 time restart ...
danken at redhat.com
danken at redhat.com
Mon Feb 11 20:24:25 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: After fail to connect to supervdsm more than 3 time restart the process
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
once upon at time we had
def _restartSupervdsm(self):
self._killSupervdsm()
self._launchSupervdsm()
but you convinced me that we should not do such things during startup. what has changed?
....................................................
File vdsm/supervdsm.py
Line 195: self._firstLaunch = False
Line 196: self._start()
Line 197: try:
Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3)
Line 199: except:
you should not swallow exception without logging and a good excuse.
Line 200: self.kill()
Line 201: self.launch()
Line 202:
Line 203: def __getattr__(self, name):
Line 197: try:
Line 198: utils.retry(self._connect, Exception, timeout=60, tries=3)
Line 199: except:
Line 200: self.kill()
Line 201: self.launch()
do you really want this recursion without an end condition? it sounds dangerous.
Line 202:
Line 203: def __getattr__(self, name):
Line 204: return ProxyCaller(self, name)
Line 205:
--
To view, visit http://gerrit.ovirt.org/11932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe112893a76686edd2949d4f40b734646fd74df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list