Change in vdsm[master]: Removing vdsm configuration when removing vdsm service

ybronhei at redhat.com ybronhei at redhat.com
Sun Feb 10 13:32:39 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Removing vdsm configuration when removing vdsm service
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm.spec.in
Line 524: 	start_conf_section="## beginning of configuration section by vdsm"
Line 525: 	end_conf_section="## end of configuration section by vdsm"
Line 526: 	by_vdsm="by vdsm"
Line 527: 
Line 528: 	/bin/sed -i -e "/${start_conf_section}/,/${end_conf_section}/d" \
Question:

when I add: -e "/${by_vdsm}/" it doesn't work at all..

any ideas why?  

(Ill remove the white spaces when I add the removal of "by vdsm" sections)
Line 529: 	       %{_sysconfdir}/libvirt/libvirtd.conf \
Line 530: 	       %{_sysconfdir}/libvirt/qemu.conf \
Line 531: 	       %{_sysconfdir}/sysconfig/libvirtd \
Line 532: 	       %{_sysconfdir}/sysctl.conf \


--
To view, visit http://gerrit.ovirt.org/11295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f59375e20efa6b5de8483a12a772f5f0ce3749
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list