Change in vdsm[master]: Removing vdsm configuration when removing vdsm service

danken at redhat.com danken at redhat.com
Thu Feb 7 12:30:55 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Removing vdsm configuration when removing vdsm service
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm.spec.in
Line 519: exit 0
Line 520: %endif
Line 521: 
Line 522: %preun
Line 523: start_conf_section="## beginning of configuration section by vdsm"
this should be done only

 if [ "$1" -eq 0 ]

and not during upgrade!

I think you should also keep supporting older code, where we had "by vdsm" ending each line. (please check which versions of vdsm had that)
Line 524: end_conf_section="## end of configuration section by vdsm"
Line 525: 
Line 526: # Removing vdsm configuration from libvirtd.conf and qemu.conf
Line 527: /bin/sed -i "/${start_conf_section}/,/${end_conf_section}/d" \


Line 522: %preun
Line 523: start_conf_section="## beginning of configuration section by vdsm"
Line 524: end_conf_section="## end of configuration section by vdsm"
Line 525: 
Line 526: # Removing vdsm configuration from libvirtd.conf and qemu.conf
I love comments, but I do not think that this one adds anything to the code. It's not even exact (there are more files).
Line 527: /bin/sed -i "/${start_conf_section}/,/${end_conf_section}/d" \
Line 528:        %{_sysconfdir}/libvirt/libvirtd.conf \
Line 529:        %{_sysconfdir}/libvirt/qemu.conf \
Line 530:        %{_sysconfdir}/sysconfig/libvirtd \


--
To view, visit http://gerrit.ovirt.org/11295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f59375e20efa6b5de8483a12a772f5f0ce3749
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list