Change in vdsm[master]: [WIP] Add new repository management code

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Thu Feb 7 09:04:15 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: [WIP] Add new repository management code
......................................................................


Patch Set 16: (1 inline comment)

1 more Q, as i understand more of this :)

....................................................
File vdsm/storage/imageRepository/imageManipulator.py
Line 475:             orphanVolumes.discard(tag.volumeId)
Line 476: 
Line 477:             if tag.isWeak():
Line 478:                 # Only weak tags have orphan potential
Line 479:                 orphanTags.add(tag.id)
Isn't there a possibility of this clashing with createVirtualDisk, where too  initially the tag is weak and then made strong.. if this clashed with that.. a potential new virtual disk can be tagged as orphan here and subsequently deleted/removed as part of fix op.. won't that be a issue ?
Line 480:                 continue
Line 481: 
Line 482:             safe.append(tag.id)
Line 483: 


--
To view, visit http://gerrit.ovirt.org/6247
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib09c89cf982b475f45d26b2428fe05e2f4565dab
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list