Change in vdsm[master]: Remove some cases of netinfo instance creation.

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Feb 6 16:21:00 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Remove some cases of netinfo instance creation.
......................................................................


Patch Set 9: Looks good to me, but someone else must approve

(1 inline comment)

just a minor suggestion inline

....................................................
File vdsm/netinfo.py
Line 551:                 self.networks[network]['iface'],
Line 552:                 self.networks[network]['bridged'], getRoutes())
Line 553:         except KeyError:
Line 554:             del self.networks[network]
Line 555:             raise
personally,   I find I still don't like re-raising  exception on delete successfully.
Line 556: 
Line 557:     def updateBonds(self, *bonds):
Line 558:         '''Updates the information for the given bonds or all bonds if no bond
Line 559:         is given.'''


--
To view, visit http://gerrit.ovirt.org/11082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cef02dc89d927799bf92d36b790598707583195
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list