Change in vdsm[master]: supervdsm: Fix race regarding instance ident

danken at redhat.com danken at redhat.com
Wed Feb 6 10:38:59 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: supervdsm: Fix race regarding instance ident
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 7: supervdsm: Fix race regarding instance ident
Line 8: 
Line 9: - Move typeid registration to module initialization as it is a class
Line 10:   level operation
Line 11: - Change callMethod() from lambda to a method and make expression
no need to be ashamed of a little typo.

I personally like it when people read my commit messages a fix their English.
Line 12:   evaluation make sense and understandable. Lambdas are tricky :)
Line 13: - Don't cache svdsm instance BaseManager does weird incref\decref and
Line 14:   indexes the transient instances by their `id(proxyObj)`. Lets just use
Line 15:   it's cache and avoid cache coherency issues.


--
To view, visit http://gerrit.ovirt.org/11759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f548cb9ad805508cf75df691e0ab58b3278dc87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list