Change in vdsm[master]: vdsm_reg: make getRemoteFile IPv6-capable

Alon Bar-Lev alonbl at redhat.com
Wed Feb 6 06:45:45 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm_reg: make getRemoteFile IPv6-capable
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 497:                       IP, port, e)
Line 498:         return None
Line 499: 
Line 500: 
Line 501: def httpGETRequest(conn, uri):
Thanks!

I think it is better to use a workaround only if needed... ask for python version and install the workaround as monkey patch.

No that this is so important for this legacy code... and this code is not required for the ovirt-host-deploy.

Anyway better to move this as internal function and add '_' prefix to mark as private.
Line 502:     response = None
Line 503: 
Line 504:     # N.B.: for python version < 2.7, http://bugs.python.org/issue5111
Line 505:     httpHeaders = {}


--
To view, visit http://gerrit.ovirt.org/11742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50cc10f3d5c5baef343fe2456c775001f712da6c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list