Change in vdsm[master]: Probe cpu count from new libvirt capabilities.

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Feb 6 03:32:53 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Probe cpu count from new libvirt capabilities.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Except a minor problem commented inline, it looks great to me!

....................................................
File tests/capsTests.py
Line 79: 
Line 80:     def testEmulatedMachines(self):
Line 81:         testPath = os.path.realpath(__file__)
Line 82:         dirName = os.path.split(testPath)[0]
Line 83:         path = os.path.join(dirName, "caps_libvirt_intel_E5649.out")
it's better to use caps_libvirt_amd_6274.out here, since it can cover the problem commit 7cf874 fixed.
Line 84:         machines = caps._getEmulatedMachines(file(path).read())
Line 85:         expectedMachines = ['rhel6.3.0', 'pc', 'rhel6.2.0', 'rhel6.1.0',
Line 86:                             'rhel6.0.0', 'rhel5.5.0', 'rhel5.4.4',
Line 87:                             'rhel5.4.0']


--
To view, visit http://gerrit.ovirt.org/11709
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e4a08cfcde6fb2e1ce4cf10478af72217c20ba5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list