Change in vdsm[master]: supervdsm: Fix race regarding instance ident

danken at redhat.com danken at redhat.com
Tue Feb 5 21:52:28 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: supervdsm: Fix race regarding instance ident
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

minor comments.

....................................................
Commit Message
Line 7: supervdsm: Fix race regarding instance ident
Line 8: 
Line 9: - Move typeid registration to module initialization as it is a class
Line 10:   level operation
Line 11: - Change callMethod() from lambda to a method and make expression
method-> local function
Line 12:   evaluation make sense and understandable. Lambdas are tricky :)
Line 13: - Don't cache svdsm instance BaseManager does weird incref\decref and
Line 14:   indexes the transient instances by their `id(proxyObj)`. Lets just use
Line 15:   it's cache and avoid cache coherency issues.


Line 12:   evaluation make sense and understandable. Lambdas are tricky :)
Line 13: - Don't cache svdsm instance BaseManager does weird incref\decref and
Line 14:   indexes the transient instances by their `id(proxyObj)`. Lets just use
Line 15:   it's cache and avoid cache coherency issues.
Line 16: 
ref https://bugzilla.redhat.com/show_bug.cgi?id=908068
Line 17: Change-Id: I4f548cb9ad805508cf75df691e0ab58b3278dc87


....................................................
File vdsm/supervdsm.py
Line 194: 
Line 195:     def getInstance(self):
Line 196:         try:
Line 197:             return self._manager.instance()
Line 198:         except:
just any exception? with no logging of the issue?! Edu is going to kill me if I take this in.
Line 199:             return None
Line 200: 
Line 201:     def launch(self):
Line 202:         self._firstLaunch = False


--
To view, visit http://gerrit.ovirt.org/11759
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f548cb9ad805508cf75df691e0ab58b3278dc87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list