Change in vdsm[master]: vdsm_reg: make the registration process IPv6 capable

Alon Bar-Lev alonbl at redhat.com
Tue Feb 5 18:56:34 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm_reg: make the registration process IPv6 capable
......................................................................


Patch Set 1: (1 inline comment)

Hello Hunt Xu,

Thank you, but most of this code is not working right now, if you can review in this sense the new ovirt-host-deploy[1], I will appreciate that.

Itamar, this is required as we did not kill the vdsm-reg, and it does not seems that we will for 3.3 either.

Alon

[1] http://gerrit.ovirt.org/gitweb?p=ovirt-host-deploy.git;a=blob;f=src/plugins/ovirt-host-deploy/vdsm/bridge.py;hb=HEAD

....................................................
File vdsm_reg/deployUtil.py.in
Line 979:                 continue
Line 980:             elif line.startswith("TYPE="):
Line 981:                 t = line.split("=", 1)[1].strip()
Line 982:                 fIsBridgeDevice = (t == "Bridge")
Line 983:             elif line.startswith("IPV6INIT="):
danken: why do these parameters are not accepted as-is within addNetwork? It is quite dirty if we need to parse the ipcfg file our-selves...
Line 984:                 ipv6 = ''.join(shlex.split(line)).split("=", 1)[1].strip()
Line 985:                 lstReturn.append("ipv6=%s" % (str(ipv6) == "yes"))
Line 986:             elif line.startswith("IPV6ADDR="):
Line 987:                 addr = ''.join(shlex.split(line)).split("=", 1)[1].strip()


--
To view, visit http://gerrit.ovirt.org/11743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b805015bdca2805d3da3bf3309fb21f973d795
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list