Change in vdsm[master]: migrateStatus() progress report

danken at redhat.com danken at redhat.com
Tue Feb 5 15:58:53 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: migrateStatus() progress report
......................................................................


Patch Set 18: I would prefer that you didn't submit this

(1 inline comment)

I'd prefer a minimalistic change, with no spelling changes and no non-urgent refactoring.

....................................................
File vdsm/libvirtvm.py
Line 393:         self.mem_progress = 0
Line 394: 
Line 395:     def run(self):
Line 396:         def calculateProgress(remaining, total):
Line 397:             return int(float(total - remaining) / total * 100)
is this change related to the patch?
Line 398: 
Line 399:         self._vm.log.debug('starting migration monitor thread')
Line 400: 
Line 401:         lastProgressTime = time.time()


--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <evilissimo at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list