Change in vdsm[master]: Fix bad image tagging when postzeroing.

ewarszaw at redhat.com ewarszaw at redhat.com
Mon Feb 4 07:26:53 UTC 2013


Eduardo has posted comments on this change.

Change subject: Fix bad  image tagging when postzeroing.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 211:     log.debug("sd: %s, LVs: %s, img: %s", sdUUID, volUUIDs, imgUUID)
Line 212:     # Prepare for zeroing
Line 213:     try:
Line 214:         lvm.changelv(sdUUID, volUUIDs, (("-a", "y"),
Line 215:                     ("--deltag", blockVolume.TAG_PREFIX_IMAGE + imgUUID),
Seems that was this way since the introduction of the function, Change-Id: I304ff5cd7.
There are not backward compatibility issues.
The volume is deleted anyway therefore the tag issue comes only if the post zeroing process is interrupted. (e.g. vdsm restarted.)
The image is easily identifiable to be partially zeroed then is only a Garbage Collection issue.
Probably there are not real cases in the wild of this issuw.
Anyway the old post zeroing process has faults too.
Line 216:                     ("--addtag", blockVolume.TAG_PREFIX_IMAGE +
Line 217:                      sd.REMOVED_IMAGE_PREFIX + imgUUID)))
Line 218:     except se.StorageException as e:
Line 219:         log.error("Can't activate or change LV tags in SD %s. "


--
To view, visit http://gerrit.ovirt.org/11593
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica92826f2d6937018fc3c384bf1377df7f541f2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list