Change in vdsm[master]: Add forceLink() which replaces a link if it already exists.

abaron at redhat.com abaron at redhat.com
Sun Feb 3 15:23:54 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Add forceLink() which replaces a link if it already exists.
......................................................................


Patch Set 2: (2 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-01-28 10:33:40 +0200
Line 6: 
Line 7: Add forceLink() which replaces a link if it already exists.
Line 8: 
Line 9: Reduce the number of fileUtils.safeUnlink() callers.
so that should be in the commit message....
Line 10: 
Line 11: Change-Id: Idea4ab66cc2954fdb11606daa4a73ad3edb0c7ef


....................................................
File vdsm/storage/fileVolume.py
Line 26: 
Line 27: from misc import deprecated
Line 28: from sdc import sdCache
Line 29: from threadLocal import vars
Line 30: import storage_exception as se
but you have 'from' before 'import os' and then from vdsm...
and volume before misc...
Line 31: import outOfProcess as oop
Line 32: import volume
Line 33: import image
Line 34: import sd


--
To view, visit http://gerrit.ovirt.org/11423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea4ab66cc2954fdb11606daa4a73ad3edb0c7ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list