Change in vdsm[master]: Fix bad image tagging when postzeroing.

abaron at redhat.com abaron at redhat.com
Sun Feb 3 15:05:21 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Fix bad  image tagging when postzeroing.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 211:     log.debug("sd: %s, LVs: %s, img: %s", sdUUID, volUUIDs, imgUUID)
Line 212:     # Prepare for zeroing
Line 213:     try:
Line 214:         lvm.changelv(sdUUID, volUUIDs, (("-a", "y"),
Line 215:                     ("--deltag", blockVolume.TAG_PREFIX_IMAGE + imgUUID),
did this never work or was the tag changed at some point? if the latter then we need to try to remove both old and new tag (not to mention the backward compatibility problems we'd need to consider, but one problem at a time).
Line 216:                     ("--addtag", blockVolume.TAG_PREFIX_IMAGE +
Line 217:                      sd.REMOVED_IMAGE_PREFIX + imgUUID)))
Line 218:     except se.StorageException as e:
Line 219:         log.error("Can't activate or change LV tags in SD %s. "


--
To view, visit http://gerrit.ovirt.org/11593
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica92826f2d6937018fc3c384bf1377df7f541f2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list